release-19.2: sql: bevy of fixes for ActiveRecord compatibility #41447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, a 'foo'::regclass query used a really inefficient way of determining the OID for a table named foo that involved getting all descriptors. This was unnecessary - the data was actually already available but not plumbed through properly. Release justification: low risk fix to existing functionality Release note (performance improvement): metadata queries that use the 'string'::regclass form are much more efficient in the presence of a large number of tables.
This commit lets the parser accept the type INTERVAL(6) as a no-op equivalent to INTERVAL. This is safe and equivalent to what we do for INTERVAL on its own. Updates cockroachdb#32564. Release justification: low-risk compatibility fix Release note (sql change): support interval precision syntax when the requested precision is exactly 6, as a syntactic sugar for intervals without a precision specified.
Closes cockroachdb#41264. Release justification: low-risk compatibility improvement Release note (sql change): add pg_available_extensions table
The special PG compatibility types int2vector and oidvector are 0-indexed, not 1-indexed like normal SQL arrays. generate_subscripts needs to respect that. This commit makes it so. Release justification: low-risk compatibility change Release note (bug fix): the generate_subscripts builtin now behaves properly on int2vector and oidvector types.
Previously, pg_get_coldesc would retrieve all comments to find a single column comment. Now it retrieves precisely what it needs. Release note (performance improvement): pg_get_coldesc is more efficient Release justification: low-risk compatibility improvement
This commit improves compatibility for the pg_attrdef table by making the default expression column less CockroachDB specific. Specifically, CockroachDB normally includes a type annotation on default expressions. Postgres doesn't do this, and doing it the CockroachDB way trips up drivers unnecessarily. Now, we strip those type annotations for this purpose only. Also, improve compatibility for pg_get_indexdef by including the index method in the returned CREATE INDEX statement. We return `btree` for the default index type, even though that's a bit of a lie, in the name of compatibility. `gin` is returned for inverted indexes as expected. Release justification: low-risk compatibility improvement Release note (sql change): improve compatibility for pg_attdef and pg_get_indexdef functions.
|
This change is |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 6/6 commits from #41323.
/cc @cockroachdb/release
'foo'::REGCLASSpg_get_coldescpg_get_indexdefandpg_attrdef.adbinto be more Postgres compatibleWith these fixes, 90% of the fork in
activerecord-cockroachdb-adaptercan go away.