storage: fix Pebble.DeleteDirAndFiles #48144
Conversation
|
This change is |
|
@asubiotto Does this matter in practice, or does it only affect tests? |
That is, should this be backported? |
|
❌ The GitHub CI (Cockroach) build has failed on e6962a6e. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
|
CI failure for |
Fix `Pebble.DeleteDirAndFiles` to actually delete the specified directory. Previously it was only recursively deleting the directory's contents. Not deleting the directory was causing the `TestDiskQueue` and `TestSpillingQueue` tests to fail which assert that the queue directory does not exist at the end of the test. This fix also addresses a TODO to use a `RemoveAll` function which has been implemented in `pebble/vfs.FS` for a while. Release note: None
petermattis
force-pushed
the
pmattis/pebble-delete-dir-and-files
branch
from
e6962a6
to
0e7b2e1
Compare
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @asubiotto)
|
TFTR!
Thank the unit tests. bors r+ |
This does not matter in practice because the flow cleans up leftover directories on |
Build succeeded |
Fix
Pebble.DeleteDirAndFilesto actually delete the specifieddirectory. Previously it was only recursively deleting the directory's
contents. Not deleting the directory was causing the
TestDiskQueueandTestSpillingQueuetests to fail which assert that the queue directorydoes not exist at the end of the test.
This fix also addresses a TODO to use a
RemoveAllfunction which hasbeen implemented in
pebble/vfs.FSfor a while.Release note: None