Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: push tenant-bound SQL codec into descriptor key generation #48376

Merged
merged 2 commits into from
May 5, 2020
Merged

sql: push tenant-bound SQL codec into descriptor key generation #48376

merged 2 commits into from
May 5, 2020

Commits on May 5, 2020

  1. sql: replace a few keys.TODOSQLCodec references with proper codecs 

    These were all pretty easy because there was a ExecutorConfig nearby.
    @nvanbenschoten
    nvanbenschoten committed May 5, 2020
    Configuration menu
    Copy the full SHA
    28d171e View commit details
    Browse the repository at this point in the history

  2. sql: push tenant-bound SQL codec into descriptor key generation 

    Informs cockroachdb#48123.

This commit continues with the plumbing that began an cockroachdb#48190. It pushes
a tenant-bound SQL codec into the other main source of key generation in
the SQL layer - descriptor manipulation and metadata handling. This
allows SQL tenants to properly handle metadata descriptors for its
database and tables.

This ended up being a larger undertaking than I had originally expected.
However, now that it's complete, we're in a pretty good spot:
1. `sqlbase.MetadataSchema` is ready to be used for cockroachdb#47904.
2. we can now run SQL migrations for a non-system tenant
3. there is only one remaining use of TODOSQLCodec in pkg/sql. See cockroachdb#48375.
    @nvanbenschoten
    nvanbenschoten committed May 5, 2020
    Configuration menu
    Copy the full SHA
    f618c80 View commit details
    Browse the repository at this point in the history