Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

util/log: delay the formatting of log entries #58031

Merged
merged 1 commit into from
Dec 28, 2020

Commits on Dec 22, 2020

  1. util/log: delay the formatting of log entries

    Prior to this patch, the logging events were converted to a
    `logpb.Entry` very early in the logging pipeline. This was forcing the
    conversion of the logging tags to a flat string too early, and making
    it hard for (e.g.) a JSON formatter to preserve the structure of
    logging tags.
    
    This patch averts this by introducing a new `logEntry` type which has
    more-or-less the same structure as `logpb.Entry` but keep the logging
    tags structured until the point the entry is formatted.
    
    Release note: None
    knz committed Dec 22, 2020
    Configuration menu
    Copy the full SHA
    a74b36a View commit details
    Browse the repository at this point in the history