build: always specify PORTABLE=1 when building RocksDB

[petermattis]

Something recently changed on the TC agents (presumably usage of a new
machine type with a different CPU) so that using -march=native when
building RocksDB causes AVX512 instructions to be used which are not
present on roachprod machines. The result is that binaries built in this
way will die with "illegal instruction". RocksDB has a mechanism to
disable the use of -march=native: pass PORTABLE=1 to the make
command. We were already doing this for release builds. Now we're doing
it for all builds.

Fixes #58754

Release note: none

[cockroach-teamcity]

This change is 

[petermattis]

Note that I only suspect that this will fix the problem as I'm not able to reproduce it locally. It is also possible that we'll need to remove the use of -march=native from cryptopp. I poked around and didn't see any obvious way to do so.

[knz]

thanks

[knz]

we'll want this on all the release branches, since we're still releasing fixes as far as 19.2.

[petermattis]

I think I can kick off a roachtest run on a specific branch. I'll try doing so and see what happens.

[petermattis]

we'll want this on all the release branches, since we're still releasing fixes as far as 19.2.

Ack. Assuming this works I'll patch 19.2 and 20.2 as well.

[petermattis]

https://teamcity.cockroachdb.com/viewQueued.html?itemId=2583885 is the roachtest run on this PR.

[RaduBerinde]

Maybe add a comment explaining what this will do. I assume it will prevent use of march=native?

[petermattis]

Yes, this prevents use of -march=native. Comment added.

[RaduBerinde]

That build failed (perhaps because of pushing a new commit?). Started a new one here: https://teamcity.cockroachdb.com/viewLog.html?buildId=2584351

[RaduBerinde]

This one failed too, with a very strange bin/roachtest: No such file or directory.

[petermattis]

make: *** No rule to make target 'vendor/modules.txt', needed by 'bin/.bootstrap'.  Stop.
make: *** Waiting for unfinished jobs....

That is from the make bin/roachtest ... invocation. Very strange as the 20.1 branch uses dep.

[petermattis]

This is probably the problem. From the Roachtest Nightly - GCE build step:

if [[ "${TC_BUILD_BRANCH}" == "release-20.1" ]] || [[ "${TC_BUILD_BRANCH}" == "release-20.2" ]]; then
    CLOUD=${TARGET_CLOUD} BUILD_TAG="${build_tag}" ./build/teamcity-nightly-roachtest.sh
    exit
fi