importccl: skip BenchmarkUserFileImport #59127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This benchmark causes repeated CI failures. Informs cockroachdb#59126. Release note: None
RaduBerinde
requested review from
nkodali,
tbg,
a team and
miretskiy
and removed request for
a team
|
This change is |
tbg
approved these changes
Jan 19, 2021
There was a problem hiding this comment.
I was just poking at this test over in #59134 and was trying to see if that PR also fixes the long test duration, but my attempt at figuring out how long it actually takes is costing me a severe amount of patience (staring at the screen for 10 minutes already). So - I don't think there's reason to believe that this test will just work after #59134, skipping seems right until bulk has had another look.
|
bors r+ |
|
Update, it did eventually pass, but I only ran it once. |
|
Build failed: |
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This benchmark causes repeated CI failures.
Informs #59126.
Release note: None