Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

streamingest: add job level test for stream ingestion #59588

Merged
merged 1 commit into from
Feb 18, 2021

Conversation

adityamaru
Copy link
Contributor

@adityamaru adityamaru commented Jan 29, 2021

This change adds a test that exercises all the components of the stream
ingestion flow. It fixes some missing pieces that were discovered while
writing the test.

Informs: #59175

Release note: None

@adityamaru adityamaru requested review from pbardea and a team January 29, 2021 17:51
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@adityamaru
Copy link
Contributor Author

Last commit is rebased on top of #59112 and #59441.

)

// Dummy import to pull in kvtenantccl. This allows us to start tenants.
var _ = kvtenantccl.Connector{}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can do this with an import line that looks like:
_ "github.com/cockroachdb/cockroach/pkg/ccl/kvccl/kvtenantccl"

pkg/sql/parser/parse_test.go Show resolved Hide resolved
Copy link
Contributor Author

@adityamaru adityamaru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @pbardea)


pkg/ccl/streamingccl/streamingest/stream_ingestion_test.go, line 45 at r4 (raw file):

Previously, pbardea (Paul Bardea) wrote…

I think we can do this with an import line that looks like:
_ "github.com/cockroachdb/cockroach/pkg/ccl/kvccl/kvtenantccl"

Done.


pkg/sql/parser/parse_test.go, line 1724 at r4 (raw file):

Previously, pbardea (Paul Bardea) wrote…

Let's also add some tests for RESTORE TABLE foo FROM ... since it's supported by the grammar. Although we error on it later, I think it's worth noting in these tests that it's a grammar that we support. A comment along with the tests explaining that we'll error out later would be good too.

Done.

@adityamaru
Copy link
Contributor Author

Going to wait for your timer change to merge before I check this in, but this should be RFAL!

Copy link
Contributor

@pbardea pbardea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after rebase.

@@ -0,0 +1,65 @@
// Copyright 2018 The Cockroach Authors.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Year needs to be updated.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@adityamaru adityamaru force-pushed the e2e-ingestion-tests branch 3 times, most recently from 82b5968 to 2d0f616 Compare February 18, 2021 02:15
This change adds a test that exercises all the components of the stream
ingestion flow. It fixes some missing pieces that were discovered while
writing the test.

Release note: None
@adityamaru
Copy link
Contributor Author

TFTR!

bors r=pbardea

@craig
Copy link
Contributor

craig bot commented Feb 18, 2021

Build succeeded:

@craig craig bot merged commit 80dd7d0 into cockroachdb:master Feb 18, 2021
@adityamaru adityamaru deleted the e2e-ingestion-tests branch February 18, 2021 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants