roachprod: Install and configure chrony on GCE clusters #62108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
I created a cluster using this change: |
Fixes cockroachdb#62063 In cockroachdb#31577 we switched to `chrony` for AWS, but not for CGE. By default they GCE clusters based on Ubuntu 16.04 use `ntp`. This patch installs `chrony` (and automatically removes `ntp`) on GCE and configures `chrony` to use Google's time server. Release note: None
|
The optional CI failures don't look related, but I can rebase again, just in case. |
|
Potentially related: #62060 |
Sounds the same to me. Thank you! |
|
Interesting. We frequently see clock offset panics in our attempts at long-running roachtests such as #47652. I had poked at that in the past and never got anywhere, but maybe this will help. Either way thank you for looking into this! |
petermattis
approved these changes
Mar 21, 2021
There was a problem hiding this comment.
I thought GCE VMs had good time synchronization out of the box that obviated the need for chrony. My knowledge is admittedly a few years out of date. I'm fine to see if this helps.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @rail)
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #62063
In #31577 we switched to
chronyfor AWS, but not for CGE. By defaultthey GCE clusters based on Ubuntu 16.04 use
ntp.This patch installs
chrony(and automatically removesntp) on GCEand configures
chronyto use Google's time server.Release note: None