clusterversion: Move JoinTokensTable,AcquisitionTypeInLeaseHistory to 21.2 #64413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
dt
approved these changes
Apr 29, 2021
knz
approved these changes
Apr 30, 2021
itsbilal
force-pushed
the
move-join-table-version
branch
from
a048644
to
6f4d874
Compare
|
TFTRs! Had to also reorder the version keys as one of the tests was checking for them being in order. |
|
let's merge #64391 first though? |
itsbilal
force-pushed
the
move-join-table-version
branch
from
6f4d874
to
98ec4e8
Compare
|
#64391 is merged, rebased on top of master. |
itsbilal
force-pushed
the
move-join-table-version
branch
from
98ec4e8
to
e731567
Compare
… 21.2 This change moves the cluster versions JoinTokensTable and AcquisitionTypeInLeaseHistory to sort after 21.1, as neither of these changes will be backported to 21.1. The JoinTokensTable migration is idempotent so it's okay if it runs twice on a small set of nodes. Release note: None.
itsbilal
force-pushed
the
move-join-table-version
branch
from
e731567
to
5907930
Compare
dt
approved these changes
Apr 30, 2021
|
Looks like some stuff in the version-upgrade acceptance test needs updating. Will take a look on Monday. |
|
Nevermind, that test got skipped as it's a master issue. bors r=dt |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First commit is #64391.
This change moves the cluster versions JoinTokensTable and
AcquisitionTypeInLeaseHistory to sort after 21.1, as neither
of these changes will be backported to 21.1. The JoinTokensTable
migration is idempotent so it's okay if it runs twice on a
small set of nodes.
Release note: None.