Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd: improve bin/reduce usability #64446

Merged
merged 1 commit into from
May 1, 2021
Merged

Conversation

mgartner
Copy link
Collaborator

This commit allows the reduce utility to be built with
make bin/reduce. It improves the help message of the program,
to describe proper usage and briefly explain how it works.

Release note: None

@mgartner mgartner requested a review from a team April 30, 2021 00:54
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Member

@RaduBerinde RaduBerinde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained

This commit allows the `reduce` utility to be built with
`make bin/reduce`. It improves the help message of the program,
to describe proper usage and briefly explain how it works.

Release note: None
@mgartner
Copy link
Collaborator Author

TFTR!

bors r+

@craig
Copy link
Contributor

craig bot commented Apr 30, 2021

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Apr 30, 2021

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented May 1, 2021

Build succeeded:

@craig craig bot merged commit 051de51 into cockroachdb:master May 1, 2021
@mgartner mgartner deleted the document-reduce branch May 4, 2021 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants