sql/schemachanger: remove cycle DepEdge rules, add SameStage kind #73290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release note: None
Just pulling symbols into the test and making the table a bit more explicit. Release note: None
Release note: None
Release note: None
Release note: None
This commit seeks to rectify an early mistake in the architecture of the declarative schema changer. In the original design, we knew we wanted certain transitions to happen in the same stage. In order to deal with that, we created rules that allowed for special types of cycles in dependencies to exist. This was a mistake. Instead, we replace this by a `Kind` property of `DepEdge`s which indicates whether the target pointed to merely needs to `HappenBefore` or whether it also needs to happen in the `SameStage`. This allows us to express exactly what we meant. This change also uncovered some broken cycles which never were intended to exist. The resultant plans generally look better. Release note: None
|
This change is |
postamar
approved these changes
Nov 30, 2021
fqazi
approved these changes
Nov 30, 2021
There was a problem hiding this comment.
Reviewed 6 of 6 files at r1, 1 of 1 files at r2, 1 of 1 files at r3, 3 of 3 files at r4, 2 of 2 files at r5, 19 of 19 files at r6, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @ajwerner)
|
TFTR bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First few commits are mostly minor cleanup. Last commit is the meat of the change.
This commit seeks to rectify an early mistake in the architecture of the
declarative schema changer. In the original design, we knew we wanted certain
transitions to happen in the same stage. In order to deal with that, we created
rules that allowed for special types of cycles in dependencies to exist. This
was a mistake. Instead, we replace this by a
Kindproperty ofDepEdgeswhich indicates whether the target pointed to merely needs to
HappenBeforeor whether it also needs to happen in the
SameStage. This allows us toexpress exactly what we meant.
This change also uncovered some broken cycles which never were intended to
exist. The resultant plans generally look better.
Release note: None