-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ui: select grants tab on table details page #73932
Conversation
Previosuly, when the grants view was selected on the Database Details page, it was going to the Table Details with the Overview tab selected. With this commit, if the view mode selected is Grant, the grant tab is selected on the Table Details page. Fixes cockroachdb#68829 Release note: None
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally, and LGTM!
Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @lindseyjin)
pkg/ui/workspaces/cluster-ui/src/databaseTablePage/databaseTablePage.tsx, line 306 at r1 (raw file):
]; render(): React.ReactElement {
Btw, what does this do? Are you just adding in the type?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @lindseyjin)
pkg/ui/workspaces/cluster-ui/src/databaseTablePage/databaseTablePage.tsx, line 306 at r1 (raw file):
Previously, lindseyjin (Lindsey Jin) wrote…
Btw, what does this do? Are you just adding in the type?
Is just showing what is the return type for the function, in this case a React Element :)
bors r+ |
Build failed (retrying...): |
Build succeeded: |
Previosuly, when the grants view was selected on the Database
Details page, it was going to the Table Details with the Overview
tab selected.
With this commit, if the view mode selected is Grant, the grant
tab is selected on the Table Details page.
Fixes #68829
Release note: None