Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spanconfig: carve empty ranges for pseudo-table IDs #74171

Merged
merged 1 commit into from
Jan 6, 2022

Commits on Jan 5, 2022

  1. spanconfig: carve empty ranges for pseudo-table IDs

    This commit is similar in spirit to cockroachdb#73746 in that it gets rid of a
    benign difference between the span configs infrastructure and the system
    config span. Whe nnabling span configs by default (cockroachdb#73876), we observed
    a wide blast radius with respect to test failures. This was in large
    part due to assumptions we've baked in regarding the number of splits we
    should expect at cluster start, often waiting for the same number of
    ranges to form before executing the rest of the test.
    
    The differences between the SystemConfigSpan and the span configs
    infrastructure in how they handled (empty) pseudo table keyspaces makes
    for an annoying large list of tests to adjust manually. Instead we take
    the lazy route and generate empty ranges for pseudo table IDs as we did
    before. We can get rid of this special handling once we actually get rid
    of the system config span, and adjust all these tests accordingly. Doing
    it later is also preferable should we need to revert pieces of cockroachdb#73876
    due to unforeseen instability.
    
    Release note: None
    irfansharif committed Jan 5, 2022
    Configuration menu
    Copy the full SHA
    a04b49b View commit details
    Browse the repository at this point in the history