*: de-flake TestPaginatedBackupTenant and remove data race #74926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
irfansharif
requested review from
ajwerner,
nvanbenschoten,
arulajmani,
adityamaru and
a team
|
This change is |
tbg
reviewed
Jan 18, 2022
tbg
reviewed
Jan 18, 2022
tbg
reviewed
Jan 18, 2022
This test readily fails under stress with span configs enabled (cockroachdb#73876). Now that we split within the tenant keyspace for tenant tables, the export requests generated for each BACKUP is liable to be retried if concurrent with range splits. The splits causes KV to error out with RangeKeyMismatchErrors, at which point the request is internally retried. The test, which wants to assert on what ExportSpan requests are intercepted, previously did not need to consider these retries/need to de-dup -- it now does. Release note: None
This test got a lot slower under the span configs infrastructure, something we're investigating as part of cockroachdb#74919. Until then, prevent this test from spoiling builds. Release note: None
Fixes cockroachdb#74932; we were reading from the replicas map without having acquired the prerequisite lock. Release note: None
irfansharif
force-pushed
the
220117.deflake-spanconfigs
branch
from
3aaf50b
to
3218353
Compare
tbg
approved these changes
Jan 18, 2022
|
bors r+ |
irfansharif
changed the title
irfansharif
changed the title
|
Build succeeded: |
arulajmani
approved these changes
Jan 18, 2022
There was a problem hiding this comment.
Reviewed 3 of 3 files at r4, 1 of 1 files at r5, 1 of 1 files at r6, all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @adityamaru, @ajwerner, @irfansharif, @nvanbenschoten, and @tbg)
23 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits; this PR squashes a data race in KV among other things.
This test readily fails under stress with span configs enabled (#73876).
Now that we split within the tenant keyspace for tenant tables, the
export requests generated for each BACKUP is liable to be retried if
concurrent with range splits. The splits causes KV to error out with
RangeKeyMismatchErrors, at which point the request is internally
retried. The test, which wants to assert on what ExportSpan requests are
intercepted, previously did not need to consider these retries/need to
de-dup -- it now does.
Release note: None