Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kvserver: deflake a deflake attempt for .. #75612

Conversation

irfansharif
Copy link
Contributor

...TestBackpressureNotAppliedWhenReducingRangeSize. Fixes #75609, a
regression we introduced in #75598. When waiting for a span config to
materialize on a given node, we were accidentally tripping up on it not
being found on the original. Not sure we this slipped CI.

Release note: None

@irfansharif irfansharif requested a review from tbg January 27, 2022 12:45
@irfansharif irfansharif requested a review from a team as a code owner January 27, 2022 12:45
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@irfansharif irfansharif force-pushed the 220127.deflake-TestBackpressureNotAppliedWhenReducingRangeSize branch from 8540cc7 to 05887bb Compare January 27, 2022 12:45
Copy link
Member

@tbg tbg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @irfansharif)

@irfansharif
Copy link
Contributor Author

72 runs so far, 0 failures, over 2m30s

Thanks!

bors r+

@irfansharif
Copy link
Contributor Author

@tbg, I think #75611 is pretty likely to fail the merge step looking at the bors history from last night. I'm going to barge in if it's all the same (sorry!).

bors r-

@craig
Copy link
Contributor

craig bot commented Jan 27, 2022

Canceled.

@irfansharif
Copy link
Contributor Author

bors r+ p=99

...TestBackpressureNotAppliedWhenReducingRangeSize. Fixes cockroachdb#75609, a
regression we introduced in cockroachdb#75598. When waiting for a span config to
materialize on a given node, we were accidentally tripping up on it not
being found on the original. Not sure we this slipped CI.

Release note: None
@irfansharif irfansharif force-pushed the 220127.deflake-TestBackpressureNotAppliedWhenReducingRangeSize branch from 05887bb to e7dcb09 Compare January 27, 2022 13:22
@craig
Copy link
Contributor

craig bot commented Jan 27, 2022

Canceled.

@irfansharif
Copy link
Contributor Author

bors r+ p=99

@craig
Copy link
Contributor

craig bot commented Jan 27, 2022

Build failed:

@irfansharif
Copy link
Contributor Author

Unrelated flake: #74396.

bors r+

@craig
Copy link
Contributor

craig bot commented Jan 27, 2022

Build failed:

@irfansharif
Copy link
Contributor Author

Still the same unrelated flake. I'll stop fighting.

bors r+ p=0

@jlinder jlinder merged commit b3ce2b7 into cockroachdb:master Jan 27, 2022
@irfansharif irfansharif deleted the 220127.deflake-TestBackpressureNotAppliedWhenReducingRangeSize branch January 27, 2022 15:11
@jlinder
Copy link
Collaborator

jlinder commented Jan 27, 2022

bors r-

@craig
Copy link
Contributor

craig bot commented Jan 27, 2022

Canceled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kv/kvserver: TestBackpressureNotAppliedWhenReducingRangeSize failed
4 participants