ccl/sqlproxyccl: add connection migration-related metrics #77700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
jaylim-crl
force-pushed
the
jay/sqlproxy-add-transfer-latency
branch
from
2f232a8
to
c1ddc64
Compare
jaylim-crl
changed the title
14 tasks
jaylim-crl
force-pushed
the
jay/sqlproxy-add-transfer-latency
branch
from
c1ddc64
to
ba4c58e
Compare
jaylim-crl
force-pushed
the
jay/sqlproxy-add-transfer-latency
branch
from
ba4c58e
to
0e7266b
Compare
jaylim-crl
commented
Mar 14, 2022
There was a problem hiding this comment.
TFTR!
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @jeffswenson)
pkg/ccl/sqlproxyccl/conn_migration.go, line 140 at r2 (raw file):
Previously, JeffSwenson (Jeff Swenson) wrote…
It would be nice to add the transfer latency to the log statements in the defer. That way we can dig into the source of unexpectedly high/low latency.
Done.
Previously, we added support for connection migration in cockroachdb#76805. This commit adds a new `proxy.conn_migration.attempted.latency` metric that tracks latency for attempted connection migrations. Having this metric would be beneficial as we can now know how long users were blocked during connection migrations. Release justification: Low-risk metric-only change within sqlproxy. Release note: None
…e size Informs cockroachdb#76000, and follow up to cockroachdb#76805. This commit adds a new proxy.conn_migration.transfer_response.message_size metric that will track the distribution of the transfer response message size. This will be used to tune a value for the SQL cluster setting: sql.session_transfer.max_session_size. Release justification: Low-risk metric-only change within sqlproxy. Release note: None
jaylim-crl
force-pushed
the
jay/sqlproxy-add-transfer-latency
branch
from
0e7266b
to
454b896
Compare
|
bors r=JeffSwenson |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ccl/sqlproxyccl: add metric that measures connection migration latency
Previously, we added support for connection migration in #76805. This commit
adds a new
proxy.conn_migration.attempted.latencymetric that tracks latencyfor attempted connection migrations. Having this metric would be beneficial
as we can now know how long users were blocked during connection migrations.
Release justification: Low-risk metric-only change within sqlproxy.
Release note: None
ccl/sqlproxyccl: add metric that records the transfer response message size
Informs #76000, and follow up to #76805.
This commit adds a new proxy.conn_migration.transfer_response.message_size
metric that will track the distribution of the transfer response message size.
This will be used to tune a value for the SQL cluster setting:
sql.session_transfer.max_session_size.
Release justification: Low-risk metric-only change within sqlproxy.
Release note: None