Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: deprecate debug unsafe-remove-dead-replicas #88730

Merged

Conversation

erikgrinaker
Copy link
Contributor

@erikgrinaker erikgrinaker commented Sep 26, 2022

This patch marks unsafe-remove-dead-replicas as deprecated, and refers users to the new recover commands. It will be removed in v23.1.

Resolves #86543.

Release note (cli change): The debug unsafe-remove-dead-replicas CLI command has been deprecated, and will be removed in v23.1. Users should use the new debug recover set of commands instead.

@erikgrinaker erikgrinaker requested review from aliher1911 and a team September 26, 2022 15:58
@erikgrinaker erikgrinaker requested review from a team as code owners September 26, 2022 15:58
@erikgrinaker erikgrinaker self-assigned this Sep 26, 2022
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@erikgrinaker
Copy link
Contributor Author

cc @mwang1026 @williamkulju

Copy link
Contributor

@aliher1911 aliher1911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 🔥

This patch marks `unsafe-remove-dead-replicas` as deprecated, and refers
users to the new `recover` commands. It will be removed in v23.1.

Release note (cli change): The `debug unsafe-remove-dead-replicas` CLI
command has been deprecated, and will be removed in v23.1. Users should
use the new `debug recover` set of commands instead.
@erikgrinaker erikgrinaker force-pushed the deprecate-unsafe-remove-dead-replicas branch from e8d24a2 to e71924e Compare September 26, 2022 16:07
@erikgrinaker
Copy link
Contributor Author

bors r=aliher1911

@craig
Copy link
Contributor

craig bot commented Sep 26, 2022

Build succeeded:

@erikgrinaker
Copy link
Contributor Author

blathers backport 22.2

@erikgrinaker erikgrinaker deleted the deprecate-unsafe-remove-dead-replicas branch October 30, 2022 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cli: deprecate unsafe-remove-dead-replicas
3 participants