upgrades: remove unused struct field #89257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
I don't know about this. I think this release is the exception more than the rule; we have upgrade steps which perform descriptor migrations more often than not. |
|
@postamar Ah, that makes sense. I was thinking that most things that interact with descriptors would be using |
ajwerner
approved these changes
Oct 4, 2022
There was a problem hiding this comment.
descs.TxnManager refactor which merged yesterday
Reviewable status:
complete! 1 of 0 LGTMs obtained
|
TIL! |
Release note: None
stevendanna
force-pushed
the
ssd/unused-struct-field
branch
from
b507b27
to
e158acf
Compare
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Epic: None
Release note: None