Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rangedesciter: carve out library for range desc iteration #89988

Merged
merged 1 commit into from
Oct 14, 2022

Conversation

irfansharif
Copy link
Contributor

@irfansharif irfansharif commented Oct 14, 2022

Informs #87503; pure code-movement. Going to use it in future commits as part of multi-tenant replication reports (#89987) where we'll need to iterate over the set of range descriptors.

Release note: None

@irfansharif irfansharif requested review from tbg, arulajmani and a team October 14, 2022 15:32
@irfansharif irfansharif requested a review from a team as a code owner October 14, 2022 15:32
@irfansharif irfansharif removed request for a team October 14, 2022 15:32
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Collaborator

@arulajmani arulajmani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 9 of 9 files at r1, all commit messages.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @tbg)

Informs cockroachdb#87503; pure code-movement. Going to use it in future commits as
part of multi-tenant replication reports (cockroachdb#89987) where we'll need to
iterate over the set of range descriptors.

Release note: None
@irfansharif
Copy link
Contributor Author

bors r+

@craig
Copy link
Contributor

craig bot commented Oct 14, 2022

Build succeeded:

@craig craig bot merged commit b0ed2bf into cockroachdb:master Oct 14, 2022
@irfansharif irfansharif deleted the 221014.rangedesc-iter branch October 14, 2022 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants