-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pgwire: split more code into pre-serve and serve logic #92576
Commits on Jan 8, 2023
-
cli/demo: fix the port allocation
Prior to this patch, we were unconditionally applying a port offset for secondary tenant servers, even when the port allocation for the KV node was randomized. This resulted in the demo cluster trying to reuse arbitrary TCP ports which may be already in use elsewhere in the system. This patch fixes it by ensuring that tenant servers also use random allocation when the KV node ports were randomly allocated in the first place. It also adds demo networking tests that verify this via the `--sql-port` / `--http-port` flags. Release note: None
Configuration menu - View commit details
-
Copy full SHA for f93343a - Browse repository at this point
Copy the full SHA f93343aView commit details -
cli/demo: deflake some interactive tests
Some of the tests were not waiting for the prompt to start sending their input. This was causing the input to be lost in some cases. Release note: None
Configuration menu - View commit details
-
Copy full SHA for a139a83 - Browse repository at this point
Copy the full SHA a139a83View commit details -
pgwire: unexport ServerMetrics, rename to tenantSpecificMetrics
Release note: None
Configuration menu - View commit details
-
Copy full SHA for cdcbeda - Browse repository at this point
Copy the full SHA cdcbedaView commit details -
Configuration menu - View commit details
-
Copy full SHA for cd68aa2 - Browse repository at this point
Copy the full SHA cd68aa2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7e86a50 - Browse repository at this point
Copy the full SHA 7e86a50View commit details -
pgwire: create a framework for pre-serve connection logic
This commit introduces `PreServeConnHandler`, which will handle the preparation of a SQL connection prior to handing it off to a specific tenant server. Release note (ops changes): The count of network bytes sent to report re-authentication errors to a SQL client is now reported via the metric `sql.pre_serve.bytesout` (instead of `sql.bytesout` previously). The count of pre-authentication errors is now reported via the metric `sql.pre_serve.conn.failures` (instead of `sql.conn.failures` previously). Release note (ops changes): The count of new SQL connections is now also reported on `sql.pre_serve.new_conns`.
Configuration menu - View commit details
-
Copy full SHA for 1814c21 - Browse repository at this point
Copy the full SHA 1814c21View commit details -
pgwire: lift readVersion + TLS handshake into the pre-serve handler
Release note (ops change): The bytes read from SQL clients prior to authentication are now reported via the metric `sql.pre_serve.bytesin` (instead of `sql.bytesin` previously).
Configuration menu - View commit details
-
Copy full SHA for e42293f - Browse repository at this point
Copy the full SHA e42293fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 54f789e - Browse repository at this point
Copy the full SHA 54f789eView commit details -
pgwire: split
parseClientProvidedSessionParameters
We need the read/parse of the parameters to be tenant-independent, so the function cannot contain tenant-specific configuration. Release note: None
Configuration menu - View commit details
-
Copy full SHA for 7bd4484 - Browse repository at this point
Copy the full SHA 7bd4484View commit details -
pgwire: split the pre-conn reserved memory account
This commit extracts the memory reservation into a tenant-independent memory pool. Release note: None
Configuration menu - View commit details
-
Copy full SHA for c7dd014 - Browse repository at this point
Copy the full SHA c7dd014View commit details