Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

logictest: avoid a lint failure #92593

Merged
merged 1 commit into from
Nov 28, 2022
Merged

logictest: avoid a lint failure #92593

merged 1 commit into from
Nov 28, 2022

Commits on Nov 28, 2022

  1. logictest: avoid a lint failure 

    The go compiler treats calls to `bazel.BuiltWithBazel()` as a
compile-time constant. Therefore,

```go
if !bazel.BuiltWithBazel() {
   skip.XXX()
}
```

is considered to always terminate execution (because `skip` does its
job by raising a panic), and any code coming after that is treated as
dead/unreachable.

Release note: None
    @knz
    knz committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    8782424 View commit details
    Browse the repository at this point in the history