logictest: refactor client connection creation logic #96469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
Depends on #96282 |
andyyang890
force-pushed
the
logictest_user_refactor_2
branch
from
8a764ce
to
295c424
Compare
This patch abstracts the logic for creating client connections and persisting them into a separate function. As a side benefit, it also fixes the problem of clients created in `execQuery` not being properly tracked in the `clients` field of `logicTest`. Release note: None
andyyang890
force-pushed
the
logictest_user_refactor_2
branch
from
295c424
to
76cc703
Compare
andyyang890
force-pushed
the
logictest_user_refactor_2
branch
from
3fcbd03
to
76cc703
Compare
rafiss
approved these changes
Feb 3, 2023
|
bors r=rafiss |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch abstracts the logic for creating client connections and
persisting them into a separate function. As a side benefit, it also
fixes the problem of clients created in
execQuerynot being properlytracked in the
clientsfield oflogicTest.Informs #92342
Release note: None