upgrades: add ExecForCountInTxns helper function for testing #98163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
rafiss
approved these changes
Mar 8, 2023
There was a problem hiding this comment.
lgtm!
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @andyyang890)
pkg/upgrade/upgrades/helpers_test.go line 178 at r1 (raw file):
t *testing.T, db *gosql.DB, count int,
would txnSize be a better name for this?
This patch adds a helper function called `ExecForCountInTxns`, which abstracts out the logic to repeatedly run SQL statements on a database in transactions of a specified size. It also refactors existing usages of this pattern to use this new function. Release note: None
andyyang890
force-pushed
the
exec_in_txns
branch
from
de2f842
to
ce8da5b
Compare
|
TFTR! bors r=rafiss |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds a helper function called
ExecForCountInTxns, which abstractsout the logic to repeatedly run SQL statements on a database in transactions
of a specified size. It also refactors existing usages of this pattern to use
this new function.
Part of #87079
Release note: None