kvserver: add minimum cpu lb split threshold #98250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
Previously, `kv.range_split.load_cpu_threshold` had no minimum setting value. It is undesirable to allow users to set this setting to low as excessive splitting may occur. `kv.range_split.load_cpu_threshold` now has a minimum setting value of `10ms`. Resolves: cockroachdb#98107 Release note (ops change): `kv.range_split.load_cpu_threshold` now has a minimum setting value of `10ms`.
kvoli
force-pushed
the
230308.min-cpu-split-thresh
branch
from
9ee220b
to
903747d
Compare
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? Thank you for updating your pull request. My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
andrewbaptist
approved these changes
Mar 9, 2023
|
TYFTR
Filed #98347 |
|
bors r=andrewbaptist |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
kv.range_split.load_cpu_thresholdhad no minimum setting value. It is undesirable to allow users to set this setting to low as excessive splitting may occur.kv.range_split.load_cpu_thresholdnow has a minimum setting value of10ms.See #96869 for additional context on the threshold.
Resolves: #98107
Release note (ops change):
kv.range_split.load_cpu_thresholdnow has a minimum setting value of10ms.