Commits on Mar 20, 2023

1. kvserver: make some cluster settings system only …

   Update cluster settings in the `kv/kvserver` pkg to be `SystemOnly`.
   Previously, there were many cluster settings which which were
   `TenantWritable`  or `TenantReadOnly`. These settings, even if altered
   by a tenant have no effect.
   
   There are settings which are not updated, due due to tests relying on
   modifying the setting value using a non-system tenant. We ignore these
   in this commit and defer to cockroachdb#98723 for handling these.
   
   These settings are updated to be `SystemOnly`:
   
   ```
   kv.bulk_io_write.max_rate
   kv.bulk_sst.max_allowed_overage
   kv.bulk_sst.target_size
   kv.closed_timestamp.follower_reads_enabled
   kv.log_range_and_node_events.enabled
   kv.range_split.by_load_enabled
   kv.range_split.load_cpu_threshold
   kv.range_split.load_qps_threshold
   kv.replica_stats.addsst_request_size_factor
   kv.replication_reports.interval
   server.shutdown.lease_transfer_wait
   ```
   
   Resolves: cockroachdb#98347
   
   Release note (ops change): Some KV server cluster settings are now system
   only. These settings could previously be written or read by
   tenants, however writing to these settings had no effect.

   

   kvoli committed Mar 20, 2023
   Configuration menu

   • View commit details
   • Copy full SHA for 7503b1a
   • Browse repository at this point

   Copy the full SHA

   7503b1a View commit details

   Browse the repository at this point in the history