Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

execinfra: correctly propagate processorID for LocalProcessors #98654

Merged
merged 1 commit into from
Mar 15, 2023

Conversation

yuzefovich
Copy link
Member

@yuzefovich yuzefovich commented Mar 15, 2023

Previously, this was incorrectly hard-coded as zero. The impact of this seems minor (I believe this would only make it so that we could incorrectly attribute ComponentStats object of planNodeToRowSource to the wrong processor), but I think it still deserves to be backported.

Epic: None

Release note: None

Previously, this was incorrectly hard-coded as zero. The impact of this
seems minor (I believe this would only make it so that we could
incorrectly attribute `ComponentStats` object of `planNodeToRowSource`
to the wrong processor), but I think it still deserves to be backported.

Release note: None
@blathers-crl
Copy link

blathers-crl bot commented Mar 15, 2023

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Collaborator

@michae2 michae2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

but I think it still deserves to be backported.

SGTM

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @DrewKimball)

@yuzefovich
Copy link
Member Author

TFTR!

bors r+

@craig
Copy link
Contributor

craig bot commented Mar 15, 2023

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Mar 15, 2023

Build succeeded:

@craig craig bot merged commit adb0556 into cockroachdb:master Mar 15, 2023
@blathers-crl
Copy link

blathers-crl bot commented Mar 15, 2023

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


error creating merge commit from 9eb8ec3 to blathers/backport-release-22.2-98654: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 22.2.x failed. See errors above.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants