Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrades: fix backfilling of special roles in user ID migrations #99097

Merged
merged 2 commits into from
Mar 21, 2023

Conversation

andyyang890
Copy link
Collaborator

upgrades: fix system.privileges user ID migration

This patch adds a missing case for the public role in the backfilling
portion of the system.privileges user ID migration.

Release note: None


upgrades: fix system.database_role_settings user ID migration

This patch adds a missing case for the empty role in the backfilling
portion of the system.database_role_settings user ID migration.

Release note: None


Part of #87079

This patch adds a missing case for the public role in the backfilling
portion of the system.privileges user ID migration.

Release note: None
@cockroach-teamcity
Copy link
Member

This change is Reviewable

This patch adds a missing case for the empty role in the backfilling
portion of the system.database_role_settings user ID migration.

Release note: None
@andyyang890 andyyang890 marked this pull request as ready for review March 21, 2023 07:57
@andyyang890 andyyang890 requested review from a team and rafiss March 21, 2023 07:57
@andyyang890
Copy link
Collaborator Author

TFTR!

bors r=rafiss

@craig
Copy link
Contributor

craig bot commented Mar 21, 2023

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Mar 21, 2023

Build succeeded:

@craig craig bot merged commit 18e6641 into cockroachdb:master Mar 21, 2023
@andyyang890 andyyang890 deleted the fix_backfilling_special branch March 21, 2023 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants