server: use no-op cost controller for shared-process tenants #99113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
knz
approved these changes
Mar 21, 2023
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @stevendanna)
pkg/server/tenant.go line 194 at r1 (raw file):
// the tenant is exempt. For now we are turning off the // tenant-side cost controller for shared-memory tenants until // we have the abilility to read capabilities tenant-side.
Can you file the followup issue and link it from here thanks
In the long run, all rate limiting of tenants should be controlled by a tenant capability. However, at the moment, we do not have the infrastructure to read tenant capabilities from the tenant process. Since, the main user of shared-process tenants is the new, experimental unified-architecture were we do not anticipate needing the cost controller for most users, this PR injects a no-op cost controller for shared-process tenants. Epic: CRDB-23559 Release note: None
This exempts the tenant from the KV-side tenant limiter. We expect this to be the default configuration of most shared-process tenants in the near term. Thus, setting this during benchmark setups provides more accurate benchmarks. Epic: none Release note: None
stevendanna
force-pushed
the
no-cost-controller-shared-process
branch
from
b2f9558
to
9e05d17
Compare
|
bors r=knz |
|
Build failed (retrying...): |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the long run, all rate limiting of tenants should be controlled by
a tenant capability.
However, at the moment, we do not have the infrastructure to read
tenant capabilities from the tenant process.
Since, the main user of shared-process tenants is the new,
experimental unified-architecture were we do not anticipate needing
the cost controller for most users, this PR injects a no-op cost
controller for shared-process tenants.
Epic: CRDB-23559
Release note: None