Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

server: use no-op cost controller for shared-process tenants #99113

Merged
merged 2 commits into from
Mar 21, 2023
Merged

server: use no-op cost controller for shared-process tenants #99113

merged 2 commits into from
Mar 21, 2023

Commits on Mar 21, 2023

  1. server: use no-op cost controller for shared-process tenants 

    In the long run, all rate limiting of tenants should be controlled by
a tenant capability.

However, at the moment, we do not have the infrastructure to read
tenant capabilities from the tenant process.

Since, the main user of shared-process tenants is the new,
experimental unified-architecture were we do not anticipate needing
the cost controller for most users, this PR injects a no-op cost
controller for shared-process tenants.

Epic: CRDB-23559

Release note: None
    @stevendanna
    stevendanna committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    96175f1 View commit details
    Browse the repository at this point in the history

  2. bench: exempt shared process tenants from rate limits 

    This exempts the tenant from the KV-side tenant limiter. We expect
this to be the default configuration of most shared-process tenants in
the near term. Thus, setting this during benchmark setups provides
more accurate benchmarks.

Epic: none

Release note: None
    @stevendanna
    stevendanna committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    9e05d17 View commit details
    Browse the repository at this point in the history