Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-22.2: roachtest: use persistent disks for disk-stall tests #99825

Closed
wants to merge 1 commit into from
Closed

release-22.2: roachtest: use persistent disks for disk-stall tests #99825

wants to merge 1 commit into from

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Mar 28, 2023 •
edited by nicktrav
Loading

Backport 1/1 commits from #99747 on behalf of @nicktrav.

/cc @cockroachdb/release

Currently, the disk-stall tests use local SSDs. When run on GCE VMs, a higher test flake rate is observed due to known issues with fsync latency for local SSDs.

Switch the test to use persistent disks instead.

Touches: #99372.

Release note: None.

Epic: CRDB-20293

Release justification: Test only.

@nicktrav
roachtest: use persistent disks for disk-stall tests
7c952ff 
Currently, the `disk-stall` tests use local SSDs. When run on GCE VMs, a
higher test flake rate is observed due to known issues with fsync
latency for local SSDs.

Switch the test to use persistent disks instead.

Touches: #99372.

Release note: None.
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-22.2-99747 branch 2 times, most recently from 0092828 to 7c952ff Compare March 28, 2023 16:36
@blathers-crl
Copy link
Author

blathers-crl bot commented Mar 28, 2023 •
edited by nicktrav
Loading

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@blathers-crl blathers-crl bot requested a review from renatolabs March 28, 2023 16:36
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Mar 28, 2023
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@nicktrav
Copy link
Collaborator

Need to amend something. Will re-open.

@nicktrav nicktrav closed this Mar 28, 2023
@nicktrav nicktrav deleted the blathers/backport-release-22.2-99747 branch March 28, 2023 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@herkolategan herkolategan Awaiting requested review from herkolategan

@jbowens jbowens Awaiting requested review from jbowens

@renatolabs renatolabs Awaiting requested review from renatolabs

Assignees

@nicktrav nicktrav

Labels
blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cockroach-teamcity @nicktrav