Commits on Mar 29, 2023

1. kv/concurrency: compute contention event duration from (key,txn) wait… …

   … start time
   
   Fixes cockroachdb#98104.
   
   This commit resolves the bug identified in cockroachdb#98104 where multiple contention
   events could be emitted with overlapping durations, such that when these
   durations were added together (e.g. by `GetCumulativeContentionTime`), their sum
   was larger than the runtime of the entire query. This was possible because as of
   70ef641, we were failing to reset the waiting start time on each new lock
   holder transaction for the same key.
   
   This commit fixes this by computing the contention event duration using
   `contentionTag.waitStart` instead of `waitingState.lockWaitStart`. It also
   cleans up some of this code and makes it harder to make such a mistake in the
   future.
   
   Release note: None

   

   nvanbenschoten committed Mar 29, 2023
   Configuration menu

   • View commit details
   • Copy full SHA for 38097f9
   • Browse repository at this point

   Copy the full SHA

   38097f9 View commit details

   Browse the repository at this point in the history