ui: small fixes to DB Console charts shown for secondary tenants #99947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
This change is |
This is due to my new machine setup. The issue has been resolved in the original PR #99860, so this will go away once that's merged & I rebase. |
abarganier
force-pushed
the
app-tenant-chart-cleanup
branch
from
38abe76
to
d45c07d
Compare
abarganier
added
the
backport-23.1.x
abarganier
force-pushed
the
app-tenant-chart-cleanup
branch
2 times, most recently
from
2f381d7
to
c691159
Compare
cockroachdb#97995 updated the DB Console to filter out KV-specific charts from the metrics page when viewing DB Console as a secondary application tenant. The PR missed a couple small details. This patch cleans those up with the following: - Removes KV latency charts for app tenants - Adds a single storage graph for app tenants showing livebytes - Removes the "Capacity" chart on the Overview dashboard for app tenants Release note: none
abarganier
force-pushed
the
app-tenant-chart-cleanup
branch
from
c691159
to
8032959
Compare
|
Okay, now that #99860 has been merged, this is ready for a review 🎉 |
dhartunian
approved these changes
Apr 7, 2023
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @abarganier)
|
TFTR! bors r=dhartunian |
|
bors r=dhartunian |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#97995 updated the
DB Console to filter out KV-specific charts from the metrics page
when viewing DB Console as a secondary application tenant.
The PR missed a couple small details. This patch cleans those
up with the following:
tenants
Release note: none
Epic: https://cockroachlabs.atlassian.net/browse/CRDB-12100
NB: Please only review the final commit. 1st commit is being reviewed separately @ #99860