Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR #102961 - sql: default sql.show_ranges_deprecated_behavior.enabled to true #16917

Closed
cockroach-teamcity opened this issue May 10, 2023 · 3 comments

Comments

@cockroach-teamcity
Copy link
Member

cockroach-teamcity commented May 10, 2023

Exalate commented:

Related PR: cockroachdb/cockroach#102961
Commit: cockroachdb/cockroach@904b301
Informs:


Release note (backward-incompatible change): The pre-v23.1 output
produced by SHOW RANGES, crdb_internal.ranges,
crdb_internal.ranges_no_leases was deprecated in 23.1, and is now
replaced by default with output that's compatible with coalesced ranges
(i.e. ranges that pack multiple tables/indexes/partitions into
individual ranges). See the 23.1 release notes for SHOW RANGES for more
details.

Jira Issue: DOC-7614

Copy link

Michael Lewis (mikeCRL) commented:
Richard Loveland I can’t find a v24.1-specific issue for this, so I’m adding it here. Would you please create a new issue if needed?

The setting {{sql.show_ranges_deprecated_behavior.enabled}} has been removed in 24.1, so when creating the 24.1 docs path, for the 24.1 copy of these files…

{noformat}/_includes/v23.1/sql/show-ranges-output-deprecation-notice.md
/_includes/v23.2/sql/show-ranges-output-deprecation-notice.md{noformat}

I had to drop the link to this setting’s anchor in settings.html, as the setting/anchor no longer exists.

You will probably want to make further updates to the file I modified — {{/src/current/_includes/v24.1/sql/show-ranges-output-deprecation-notice.md}}. I only did the bare minimum (dropping the anchor!) so that the preview build would pass in that PR. Previously, I was getting {{htmltest}} errors.

Copy link

Richard Loveland (rmloveland) commented:
thanks Michael Lewis , filed https://cockroachlabs.atlassian.net/browse/DOC-9875 to address

Copy link

Richard Loveland (rmloveland) commented:
This is now fixed by #18418

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants