Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify utility of indexes for UPDATES and DELETES #4819

Closed
jseldess opened this issue May 17, 2019 · 6 comments
Closed

Clarify utility of indexes for UPDATES and DELETES #4819

jseldess opened this issue May 17, 2019 · 6 comments
Labels
C-doc-improvement P-2 Normal priority; secondary task

Comments

@jseldess
Copy link
Contributor

@thatnerd clarified why secondary indexes can slow down inserts, but in conversation, he also clarified the potential speed up for the seek portion of an update or delete when not filtering on the primary key. I just read our main index doc and SQL best practices and this guidance is completely missing, I think. We only talk about the impact of indexes on "queries", which I think is too vague. We should fix that.

@jseldess jseldess added A-sql P-1 High priority; must be done this release C-doc-improvement labels May 17, 2019
@jseldess jseldess added this to the 19.2 milestone May 17, 2019
@jseldess
Copy link
Contributor Author

@thatnerd, you want to take this?

@thatnerd
Copy link
Contributor

On it.

@thatnerd
Copy link
Contributor

Going to try to figure out the previous PR first, then do this.

@thatnerd
Copy link
Contributor

@rmloveland
Copy link
Contributor

Is this really P-1? I agree that we should provide this guidance in our docs, but it's not clear it "needs to be done this release" (the P-1 standard) since it's a worthy but IMO non-urgent performance optimization tip. Gonna bump to P-2 and remove from milestone, shout if you strongly disagree.

@rmloveland rmloveland removed this from the 19.2 milestone Aug 8, 2019
@rmloveland rmloveland added P-2 Normal priority; secondary task and removed P-1 High priority; must be done this release labels Aug 8, 2019
@awoods187
Copy link
Contributor

Closing this in favor of the new documentation on batch deletes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-doc-improvement P-2 Normal priority; secondary task
Projects
None yet
Development

No branches or pull requests

4 participants