Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font spacing is tight #9430

Closed
Annebirzin opened this issue Jan 21, 2021 · 1 comment
Closed

Font spacing is tight #9430

Annebirzin opened this issue Jan 21, 2021 · 1 comment
Assignees
Labels
P-0 Urgent; must be done in next 2 weeks

Comments

@Annebirzin
Copy link

Annebirzin commented Jan 21, 2021

Spacing between text in list items feels tight (screenshot 1)
Spacing between body copy and code snippits feels tight (screenshot 2)

Screen Shot 2021-01-21 at 11 33 10 AM

Screen Shot 2021-01-21 at 11 14 29 AM

@Annebirzin Annebirzin changed the title Spacing above/below code snippits feels tight Spacing between body copy and code snippits feels tight Jan 21, 2021
@Annebirzin Annebirzin changed the title Spacing between body copy and code snippits feels tight Font spacing is tight Jan 21, 2021
@lnhsingh lnhsingh added the P-0 Urgent; must be done in next 2 weeks label Jan 21, 2021
@luciaaaaaaa luciaaaaaaa self-assigned this Jan 21, 2021
@luciaaaaaaa
Copy link

luciaaaaaaa commented Jan 26, 2021

Design fix:

For 1. "Spacing between text in list items feels tight (screenshot 1)" Vertical spacing in numbered lists should match spacing in bullet lists and should be concistent accross all lists.
See bullet vs. numbered lists spacing in this link for reference: https://600fd229b7cea40008a185f2--cockroachdb-docs.netlify.app/docs/cockroachcloud/create-your-cluster.html

For 2. "Spacing between body copy and code snippits feels tight (screenshot 2)" This might be related to 1 because it is also a numbered list. It also looks like the tabs are pushing all the code-box down, making it look like the code relates to the description that is below it rather than on top.
Here is a wireframe that shows spacing with code-box in context https://www.figma.com/file/6XcxaUdad2RkjpEqnVHKAG/Education-docs-redesign?node-id=2228%3A12437
Fix should follow the padding determined on 1., and tab height should be at its minimum

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P-0 Urgent; must be done in next 2 weeks
Projects
None yet
Development

No branches or pull requests

4 participants