Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster-ui: update crdb-protobuf-client #220

Merged
merged 1 commit into from
Feb 25, 2021
Merged

cluster-ui: update crdb-protobuf-client #220

merged 1 commit into from
Feb 25, 2021

Conversation

asubiotto
Copy link
Contributor

This PR has no UI changes. It updates the code to work with the latest crdb-protobuf-client refactor and adds handling for new protobuf fields. The latest protobuf field is still pending merge cockroachdb/cockroach#60791, so a 0.0.7-beta.1 version has been published in the meantime for this PR to work.

Copy link
Contributor

@dhartunian dhartunian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Feel free to merge once we have a published client version.

@asubiotto
Copy link
Contributor Author

TFTR! Will publish once the linked PR is merged and update package.json before merging this.

@asubiotto asubiotto merged commit 76b2b3b into cockroachdb:master Feb 25, 2021
@asubiotto asubiotto deleted the exec-stats branch February 25, 2021 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants