cluster-ui: miscellaneous fixes and additions to statements/transactions page/details #222
Conversation
|
The commits are separated for ease of review. Let me know if you would prefer me to squash them. |
|
Need to update tests that assert the sort key. |
|
The PR this depends on has now been merged so this is ready for a review. |
There was a problem hiding this comment.
Reviewed 12 of 12 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @asubiotto, @nathanstilwell, and @nkodali)
packages/cluster-ui/src/statementsTable/statementsTable.tsx, line 85 at r1 (raw file):
// TODO(asubiotto): Looks like none of these class names are defined? // What's going on here? className: cx("statements-table__col-contention"),
I think you only need these if you want to override the widths of the column. We had a prior change where I pushed a commit eliminated most of these customer classes since they were unnecessary in most cases.
This column is no longer necessary because the transactions page exists.
The default sort order is specified using a column index. Previous commits that rearranged these columns did not update the index, so an erroneous sort order was observed.
…on details This limits the number of decimal places to two, achieving better aesthetic consistency.
This commit adds a contention time column that displays the amount of time a statement spent contending and the cumulative time a transaction's statements spent contending cumulatively in each respective page.
|
Gotcha. Removed the undefined ones (that I think I added 😂 ) |
The first commit in this PR is #220, which should go in before this.
This PR addresses a lot of the nits observed in @awoods187' testing outlined in cockroachdb/cockroach#60001.
The last two commits add contention and max disk usage information to the pages based on previously agreed on designs by @Annebirzin. Here are some visuals:
Contention Time
Max scratch disk usage