Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

acedently overpaying when buying an option #328

Closed
HardlyDifficult opened this issue May 31, 2022 · 2 comments
Closed

acedently overpaying when buying an option #328

HardlyDifficult opened this issue May 31, 2022 · 2 comments
Labels
invalid This doesn't seem right

Comments

@HardlyDifficult
Copy link
Collaborator

From MadWookie in #164

File:Cally.sol#224
require(msg.value >= premium, "Incorrect ETH amount sent");
Using == operator is 3 gas cheaper than >=. This also keeps people from acedently overpaying when buying an option.

Summary
Implementing each of these would reduce the deploymnt cost from 5,431,682 to 5,387,621 and reduces buyOption from 75,765 to 75,013.
@HardlyDifficult HardlyDifficult added bug Something isn't working duplicate This issue or pull request already exists 2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value labels May 31, 2022
@HardlyDifficult
Copy link
Collaborator Author

Dupe of #84

@HardlyDifficult HardlyDifficult mentioned this issue May 31, 2022
Open
@JeeberC4 JeeberC4 added invalid This doesn't seem right and removed bug Something isn't working duplicate This issue or pull request already exists 2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value labels Jun 6, 2022
@JeeberC4
Copy link
Contributor

JeeberC4 commented Jun 6, 2022

Issue recreated with script that includes all required data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
invalid This doesn't seem right
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@HardlyDifficult @JeeberC4