ERC677 onTokenTransfer return value not check

[code423n4]

Lines of code

https://github.com/code-423n4/2023-05-chainlink/blob/709cde28937727a729b9b5a6653e3720227f9897/contracts/pools/tokens/ERC677.sol#L20

Vulnerability details

Impact

According to the ERC677 specification, the onTokenTransfer interface has a bool return, but the code implementation does not check this return value.
This results in a problem with callback of receiver contract, when the receiver contract rejects the call, it may only return false and not revert. However, according to the code implementation, the callback will succeed silently.

Proof of Concept

Receiving Contract
onTokenTransfer
function onTokenTransfer(address from, uint256 amount, bytes data) returns (bool success)

  function transferAndCall(address to, uint amount, bytes memory data) public returns (bool success) {
    super.transfer(to, amount);
    emit Transfer(msg.sender, to, amount, data);
    if (to.isContract()) {
      // @audit should check return value
      IERC677Receiver(to).onTokenTransfer(msg.sender, amount, data);
    }
    return true;
  }

Tools Used

Manual review

Recommended Mitigation Steps

check onTokenTransfer return value

Assessed type

CanAuto

[code423n4]

Withdrawn by kutugu