-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Severity standardization - NFT metadata #109
Comments
As commented in one of the issue, I don't see them having high/med security impact because sanitation should be done by the frontend, which on its own can also inject malicious script. It also required privileged role to set those data in the Llama case. |
To clarify, in Llama anyone can deploy a DAO, set up malicious data in DAO NFT, and launch an attack as long as someone else loads NFT image in the web page, such as browsing NFTs in opensea. |
Anyone can also deploy any smart contract or NFT too, I am sure OpenSea would not assume the tokenURI is safe. |
I also side with QA unless the Web Part of the site was in scope |
We don't seem to have a standard severity of NFT metadata, so I created the issue to discuss.
There are two main problems:
LlamaPolicyMetadata.contractURI()
can return corrupted JSON data 2023-06-llama-findings#254tokenURI
JSON injection 2023-03-canto-identity-findings#212The focus is on whether this issue should be filtered by the front end or the smart contract.
Welcome to discuss and supplement the case.
The text was updated successfully, but these errors were encountered: