Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue identified the root causes and effects, but was considered ineffective, hoping for justice. #156

Open
wangxx2026 opened this issue Mar 29, 2024 · 2 comments

Comments

@wangxx2026
Copy link

code-423n4/2024-02-wise-lending-findings#197

I believe this issue has been treated unfairly. The description of the problem was simplified, I admit that. However, we can see that the issue was initially marked as valid and successfully categorized. So I can assume that the issue was understood correctly. The issue points out the root cause and its adverse effects. I kept it brief because I assumed the judge is familiar with the code and I highlighted the points that should be sufficient for the judge to understand without going into excessive detail. If my understanding is incorrect, I will change the way I raise issues in the future. But I find it difficult to accept that this issue has been labeled as "unsatisfactory."

@trust1995
Copy link

Hey @wangxx2026

  • Please label the issue in a more descriptive way
  • When making a case it is customary to include any responses so people can have a balanced view. In this case, the ruling was based on the following Supreme Court verdicts: one two

@wangxx2026 wangxx2026 changed the title Judging Issue is unfairly judged Mar 30, 2024
@wangxx2026 wangxx2026 changed the title Issue is unfairly judged Issue identified the root causes and effects, but was considered ineffective, hoping for justice. Mar 31, 2024
@wangxx2026
Copy link
Author

wangxx2026 commented Apr 1, 2024

Hey @trust1995
For one,I think I provided the STEP BY STEP poc and I put a link on the function without referencing the code in. You can see the referenced function, and the affected function in the issue. I think it's useful that the issue was successfully understood and categorized. My intention in doing this was originally to make the reading smoother.

In two, I noticed the "quality score", I don't know what the rules are for this score?
In the issue, you can see @GalloDaSballo's comment "A coded POC would have been better, worth checking". But now it's suddenly changed to "Insufficient quality".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants