Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Severity standardization - Protocol does not support CryptoPunks #77

Closed
trust1995 opened this issue Dec 18, 2022 · 3 comments
Closed

Severity standardization - Protocol does not support CryptoPunks #77

trust1995 opened this issue Dec 18, 2022 · 3 comments

Comments

@trust1995
Copy link

Cryptopunks do not conform to ERC721. Since the majority of NFT-centric protocols use the ERC721 interface to interact with NFTs, they do not support CryptoPunks without some additional wrapping. It is a very common report to see in NFT related contests, and has in the past mostly been judged as QA:

Nibble - QA
Blur - QA
PartyDAO - QA
Cally - QA
Foundation - MED

Note that in the Nibble discussion, the judge which was the Foundation sponsor remarked that it was too generous to Ack as MED.

It seems like, by our severity guidelines, the issue is QA level. Punks can be wrapped externally and treated as ERC721. Also it sounds more like a feature request than something that is automatically assumed to be available.

Feel free to post feedback below.

@dmvt
Copy link

dmvt commented Dec 18, 2022

I agree 100% with this. This issue should be QA.

@GalloDaSballo
Copy link

Low because you can wrap them

@KnownFactC4
Copy link

Per the Autumn 2023 C4 Supreme Court verdicts, the Supreme Court's verdict on this issue is:

QA as Refactoring / Improvement
Cannot be argued as a vulnerability

Link to verdict: https://docs.google.com/document/d/1Y2wJVt0d2URv8Pptmo7JqNd0DuPk_qF9EPJAj3iSQiE/edit#heading=h.7ut9cawrjeap

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants