Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detail/Description section is broken #1608

Closed
OshidaBCF opened this issue Mar 14, 2023 · 16 comments
Closed

Detail/Description section is broken #1608

OshidaBCF opened this issue Mar 14, 2023 · 16 comments
Labels
Bug Bug or required update after YouTube changes help wanted Just an old github standard we add automatically. (The team can remove it when working on it.)

Comments

@OshidaBCF
Copy link

OshidaBCF commented Mar 14, 2023

Bug Report:

BUG: Description + Detail of videos is gone

HOW: Install the extention and open any video

EXPECTED (/preferred) behavior: S1 is supposed to appear, instead S2 appear (S3 appear if i set Appearance > Details > Description to "normal" instead of "hidden")

Screenshots:
S1 : image
S2 : image
S3 : image

/ ⚬ Context: I do not remember if the Appearance > Details > Description setting is set to "hidden" or "normal" by default, but in both case it shows a weird mix of youtube's new and old UI

Setup:

⚬ ImprovedTube Version: 4.1
⚬ Browser: Chrome 110.0.5481.180
⚬ Settings: settings.txt
⚬ OS: Win 10

@OshidaBCF OshidaBCF added Bug Bug or required update after YouTube changes help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) labels Mar 14, 2023
@ImprovedTube
Copy link
Member

ImprovedTube commented Mar 14, 2023

hi @OshidaBCF, our default is no change.
wonder how you noticed something if you had it set to hidden?

the current normal will be renamed to: classic
( expanded will be renamed to classic expanded )

thus a new normal & expanded will be added.

@OshidaBCF
Copy link
Author

OshidaBCF commented Mar 14, 2023

wonder how you noticed something if you had it set to hidden?

Maybe youtube rolled an update, but before i could see "youtube's" Detail and Desc yesterday, now it's hidden in all the settings of the extension

thus a new normal & expanded will be added.

sweet

@HanabishiRecca
Copy link

HanabishiRecca commented Mar 15, 2023

wonder how you noticed something if you had it set to hidden?

Before the update the option only affected "classic" details page. But "modern" one always was visible.
After the update modern detais page are always hidden. And there is no way to bring it back atm, if I got it right. (Not counting disabling the extension entirely.)

@OshidaBCF
Copy link
Author

Indeed, i don't want to disable the extension because it's sooo useful

@lokzz
Copy link

lokzz commented Mar 17, 2023

downgrade moment

@ImprovedTube
Copy link
Member

ImprovedTube commented Mar 17, 2023

hi @HanabishiRecca @OshidaBCF @jacklolidk

hidden
maybe youtube rolled an update

should only hide if both are present ( through CSS ) old + new { display: none !important;}

So you guys didnt mind two🙈😖descriptions? ( wondered why it didnt cause the most noticeable extra uninstalls of all our bugs yet. )

...can always try the latest edit: https://github.com/code-for-charity/ImprovedTube-for-YouTube/archive/refs/heads/master.zip
besides 4.2 is live in the stores / Beta now.

@HanabishiRecca
Copy link

So you guys didnt mind two🙈😖descriptions?

That is exactly why "Description > hidden" did the trick. I personally don't really mind, but it should be controllable anyway imo.

Also YT may completely remove remnants of the old design in any moment. This will happen eventually no doubt. So relying on it is not the best idea, I think.

@OshidaBCF
Copy link
Author

So you guys didnt mind two🙈😖descriptions? ( wondered why it didnt cause the most noticeable extra uninstalls of all our bugs yet. )

Well i didn't had 2, i had nearly one

@OshidaBCF
Copy link
Author

besides 4.2 is live in the stores

Doesn't appear live yet for me, or googles updater is a bit slow to catch up

@OshidaBCF
Copy link
Author

I downloaded and installed the "manual" 4.2, and setting description to "normal" fixed it

Thanks a lot

@OshidaBCF
Copy link
Author

Update: the version 4.2 now have a weird glitch where if i open the description thing, the page just "scroll" up a bit by itself, trying to put the video in the center of the screen.

It also seems to do it without me opening the description, just "loading" the description does that sometime

2023-03-17.20-59-54.mp4

@ImprovedTube
Copy link
Member

@OshidaBCF That's while the page isn't fully loaded? @MohamedLebda

@OshidaBCF
Copy link
Author

Cant tell, it seems to happen even after the page loaded

@MohamedLebda
Copy link
Contributor

the version 4.2 now have a weird glitch where if i open the description thing, the page just "scroll" up a bit by itself, trying to put the video in the center of the screen.

to help me understand the issue better :
you downloaded the extension then you didn't change any settings in the extension then opened a youtube video on chrome clicked on see more in the description the issue in your video happens?

@ImprovedTube
Copy link
Member

ImprovedTube commented Mar 18, 2023

@OshidaBCF stops after some seconds. (fixing ASAP anyways)
we meant 'show less' as feedback once, when setting 'normal', but put it at page load & MutationOberserver (when elements get added to the page)

(Youtube does the scrolling)

@MohamedLebda yes

@OshidaBCF
Copy link
Author

Basically yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Bug or required update after YouTube changes help wanted Just an old github standard we add automatically. (The team can remove it when working on it.)
Projects
None yet
Development

No branches or pull requests

5 participants