Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default shortcuts for increase/decrease playback speed #664

Open
ShlomiRex opened this issue Dec 5, 2020 · 4 comments
Open

Default shortcuts for increase/decrease playback speed #664

ShlomiRex opened this issue Dec 5, 2020 · 4 comments
Labels
Feature request Wish or idea good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) Rare use-case? Rare / Niche (or just for fun?) Or to become a remainder replaced by a successor or anything. Structures (UX) & ORG Let's focus on structure! Everything should be as easily seen/found as or where it is relevant. up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥

Comments

@ShlomiRex
Copy link

ShlomiRex commented Dec 5, 2020

PROBLEM:
No default shortcuts for playback speed

SOLUTION:
Add default configuration

RELEVANCE / SCOPE:
User doesn't have to assign manually keyboard shortcut

"SIDE EFFECTS":
May conflict with other keyboard shortcuts. Need discussion about this issue.

I suggest Alt + '=' and Alt + '-' for increase/decrease playback speed.
You can suggest your ideas.

Tested on Windows and macOS. This shortcut is available for both. (Alt in macOS is the Option key.)

@ghost ghost removed the Help Wanted label Dec 11, 2020
@ghost ghost changed the title (IDEA) Default shortcuts for increase/decrease playback speed Default shortcuts for increase/decrease playback speed Dec 11, 2020
@ghost ghost added the 💭Question🌱 Q & A (We can move it to the 'Discussions'-Section, if no other label applies) label Dec 11, 2020
@ImprovedTube ImprovedTube added the help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) label Dec 13, 2020
@platinorum
Copy link
Contributor

I agree that default shortcuts would be useful.
Relatively onkown, YouTube itself has default hotkeys. They are SHIFT + , (increase playback speed by 0.25) and SHIFT + . (decrease playback speed by 0.25).
I personally use PAGEUP for increasing and PAGEDOWN for decreasing the speed, but I am aware many people have a smaller keyboard without a number block and those keys.

@ImprovedTube
Copy link
Member

ImprovedTube commented Apr 12, 2021

@ShlomiRex sounds good btw, besides ImprovedTube comes with 0 defaults just yet. And most people use no shortcuts.
however we should probably add default buttons
#857 #1445

@ImprovedTube ImprovedTube added Feature request Wish or idea Rare use-case? Rare / Niche (or just for fun?) Or to become a remainder replaced by a successor or anything. and removed 💭Question🌱 Q & A (We can move it to the 'Discussions'-Section, if no other label applies) labels Dec 28, 2021
@ImprovedTube ImprovedTube added the Structures (UX) & ORG Let's focus on structure! Everything should be as easily seen/found as or where it is relevant. label Sep 29, 2022
@horseDeveloper
Copy link

horseDeveloper commented Aug 24, 2023

@ImprovedTube I noticed that now the extension comes with < and > as defaults.
In my case (Firefox 116.0.3 (64-bit)) they don't work as YouTube defaults to its own speed increments: this means that even if I had a 0.05 increment (see img below) YouTube defaulted to their 0.25 increment.
image

The extension is missing a feature that YouTube Enhancer had, which is the ability to have a shortcut for "set speed to 1", it's already mentioned in some other feature requests.

I suggest choosing some keys that don't overlap with YouTube shortcuts to avoid conflicts. IMO for international keyboards the best choice would be [ , ] and \ as it's efficient for the main keyboard layouts. \ if the new 3rd shortcut to "set speed to 1" is implemented.
image

@ImprovedTube
Copy link
Member

TYSM! @horseDeveloper

"set speed to 1"

Called shortcuts: speed: reset


By default, we only show YouTube's shortcut's for information with the users in mind who don know everything and would rather think of a single list of short cuts than two #517

Our shortcuts code needs an adoptive parent asap: #1770 (bug) )

  • global option / outside of the tab
  • support chrome://extensions shortcuts too (just because we have something more, doesn't mean we need to give up on the standard)

@ImprovedTube ImprovedTube added good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥ labels Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature request Wish or idea good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) Rare use-case? Rare / Niche (or just for fun?) Or to become a remainder replaced by a successor or anything. Structures (UX) & ORG Let's focus on structure! Everything should be as easily seen/found as or where it is relevant. up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥
Projects
None yet
Development

No branches or pull requests

4 participants