Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Screenshot icon clipping out while playing a video with timestamps. #894

Closed
User198263321 opened this issue May 13, 2021 · 3 comments
Closed

Screenshot icon clipping out while playing a video with timestamps. #894

User198263321 opened this issue May 13, 2021 · 3 comments
Labels
Bug Bug or required update after YouTube changes help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) Rare use-case? Rare / Niche (or just for fun?) Or to become a remainder replaced by a successor or anything.

Comments

@User198263321
Copy link

image
https://www.youtube.com/watch?v=b1Fo_M_tj6w
^ Example link
Hovering over the volume icon makes the issue more visible.

It gets worse if you use sponsorblock with "Show time with skips removed enabled
image

Again, hovering over the volume icon makes the issue more visible.

Extension V3.232
@User198263321 User198263321 added the help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) label May 13, 2021
@User198263321
Copy link
Author

It could be screen size dependant?

@User198263321 User198263321 changed the title Screenshot icon clipping out while playing a video with timestamps. Screenshot icon clipping out while playing a video with timestamps. [SponsorBlock] Jul 9, 2021
@User198263321 User198263321 changed the title Screenshot icon clipping out while playing a video with timestamps. [SponsorBlock] Screenshot icon clipping out while playing a video with timestamps. Jul 9, 2021
@ImprovedTube ImprovedTube added Bug Bug or required update after YouTube changes Rare use-case? Rare / Niche (or just for fun?) Or to become a remainder replaced by a successor or anything. labels Dec 27, 2021
@ImprovedTube
Copy link
Member

ImprovedTube commented Dec 27, 2021 •
edited
Loading

it would be the only solution given two points:

  • 'we should (never) reduce the gap between default buttons, since it could cause misclicks in fast usage without looking.'
  • 'half a screenshot button is better than none'

in your specific scenario we could shrink the screenshot button or show it below the below instead (same horizontal position) (however all of that would be complicated)

( We can just use permanent positions outside of the player #1445 and let users decided if these shall be permanent or fade in simultanously with youtube's player controls)

@ghost
Copy link

ghost commented Feb 3, 2022

Fixed

@ghost ghost closed this as completed Feb 3, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Bug or required update after YouTube changes help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) Rare use-case? Rare / Niche (or just for fun?) Or to become a remainder replaced by a successor or anything.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ImprovedTube @User198263321