From eb7d629580a788a0f315179ce67b594d0c92a2fe Mon Sep 17 00:00:00 2001 From: hanna-skryl Date: Tue, 13 Aug 2024 10:58:55 -0400 Subject: [PATCH] feat(plugin-lighthouse): omit audit details table title --- .../src/lib/runner/details/details.unit.test.ts | 1 - packages/plugin-lighthouse/src/lib/runner/details/table.type.ts | 1 - .../src/lib/runner/details/table.type.unit.test.ts | 2 -- packages/plugin-lighthouse/src/lib/runner/utils.unit.test.ts | 1 - 4 files changed, 5 deletions(-) diff --git a/packages/plugin-lighthouse/src/lib/runner/details/details.unit.test.ts b/packages/plugin-lighthouse/src/lib/runner/details/details.unit.test.ts index 0214f661d..4cdcb142f 100644 --- a/packages/plugin-lighthouse/src/lib/runner/details/details.unit.test.ts +++ b/packages/plugin-lighthouse/src/lib/runner/details/details.unit.test.ts @@ -89,7 +89,6 @@ describe('toAuditDetails', () => { expect(outputs).toStrictEqual({ table: { - title: 'Table', columns: [ { key: 'name', diff --git a/packages/plugin-lighthouse/src/lib/runner/details/table.type.ts b/packages/plugin-lighthouse/src/lib/runner/details/table.type.ts index aea4c1b0f..74cc7fc8c 100644 --- a/packages/plugin-lighthouse/src/lib/runner/details/table.type.ts +++ b/packages/plugin-lighthouse/src/lib/runner/details/table.type.ts @@ -19,7 +19,6 @@ export function parseTableToAuditDetailsTable( try { return tableSchema().parse({ - title: 'Table', columns: parseTableColumns(rawHeadings), rows: items.map(row => parseTableRow(row, rawHeadings)), }); diff --git a/packages/plugin-lighthouse/src/lib/runner/details/table.type.unit.test.ts b/packages/plugin-lighthouse/src/lib/runner/details/table.type.unit.test.ts index bcad1e465..46958974d 100644 --- a/packages/plugin-lighthouse/src/lib/runner/details/table.type.unit.test.ts +++ b/packages/plugin-lighthouse/src/lib/runner/details/table.type.unit.test.ts @@ -93,7 +93,6 @@ describe('parseTableToAuditDetails', () => { } satisfies Details.Table); expect(outputs).toStrictEqual({ - title: 'Table', columns: [ { key: 'statistic', @@ -219,7 +218,6 @@ describe('parseTableToAuditDetails', () => { } as Details.Table); expect(outputs).toEqual({ - title: 'Table', columns: [ { align: 'left', diff --git a/packages/plugin-lighthouse/src/lib/runner/utils.unit.test.ts b/packages/plugin-lighthouse/src/lib/runner/utils.unit.test.ts index 6423eccd9..b6e4a6d46 100644 --- a/packages/plugin-lighthouse/src/lib/runner/utils.unit.test.ts +++ b/packages/plugin-lighthouse/src/lib/runner/utils.unit.test.ts @@ -150,7 +150,6 @@ describe('toAuditOutputs', () => { table: { columns: [{ key: 'number', align: 'left' }], rows: [{ number: 42 }], - title: 'Table', }, }); });