Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Hide MyMLH button if MLH_KEY env var is not set #167

Merged
merged 2 commits into from
Jun 18, 2019
Merged

feat: Hide MyMLH button if MLH_KEY env var is not set #167

merged 2 commits into from
Jun 18, 2019

Conversation

dquach217
Copy link
Contributor

Fixes #154

@dquach217 dquach217 requested a review from sman591 June 17, 2019 02:09
sman591
sman591 requested changes Jun 17, 2019
View reviewed changes
Copy link
Member

@sman591 sman591 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This hides the entire form, making it impossible to login or register; only the My MLH section should be hidden (lines 2 through 6). Also ensure that it visually looks OK in both MLH and non-MLH mode.

I highly recommend always testing changes locally before submitting a PR -- happy to help get HM running locally if needed

sman591
sman591 approved these changes Jun 18, 2019
View reviewed changes
Copy link
Member

@sman591 sman591 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sman591 sman591 changed the title Check for Environment Variable feat: Hide MyMLH button if MLH_KEY env var is not set Jun 18, 2019
@sman591 sman591 merged commit 9b81034 into master Jun 18, 2019
@sman591 sman591 deleted the issue_154 branch June 18, 2019 05:55
sman591 pushed a commit that referenced this pull request Jun 18, 2019
@semantic-release-bot
chore(release): 1.14.0 [skip ci]
2737954 
# [1.14.0](v1.13.1...v1.14.0) (2019-06-18)

### Documentation

* **dokku:** Clarify .conf files to create ([1745f00](1745f00))
* **dokku:** Clarify steps to edit Nginx files + sudo ([8057801](8057801))
* **dokku:** Clear up nginx setup description ([4b20eab](4b20eab))

### Features

* Hide MyMLH button if MLH_KEY env var is not set ([#167](#167)) ([9b81034](9b81034))
* Link "home" button to marketing site ([#166](#166)) ([d65416d](d65416d))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sman591 sman591 sman591 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hide MyMLH button if MLH_KEY env var is not set
2 participants
@dquach217 @sman591