Skip to content

Commit

Permalink
dashboard: require at least Go 1.13 for darwin-386 builder
Browse files Browse the repository at this point in the history
release-branch.go1.12 has failures for darwin-386-10_14, which are fixed
in Go 1.13. darwin-386 is not a first-class port and on a deprecated
architecture for macOS, and can be skipped on older branches.

Fixes golang/go#33756

Change-Id: I5f2e95fe9515978a85b986787d8126655f849629
Reviewed-on: https://go-review.googlesource.com/c/build/+/191878
Run-TryBot: Alexander Rakoczy <alex@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
  • Loading branch information
toothrot authored and codebien committed Nov 13, 2019
1 parent c1dda10 commit b3adf7c
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 5 deletions.
8 changes: 5 additions & 3 deletions dashboard/builders.go
Original file line number Diff line number Diff line change
Expand Up @@ -1914,9 +1914,11 @@ func init() {
Name: "darwin-386-10_14",
HostType: "host-darwin-10_14",
shouldRunDistTest: macTestPolicy,
buildsRepo: onlyGo,
MaxAtOnce: 1,
env: []string{"GOARCH=386", "GOHOSTARCH=386"},
buildsRepo: func(repo, branch, goBranch string) bool {
return repo == "go" && atLeastGo1(branch, 13)
},
MaxAtOnce: 1,
env: []string{"GOARCH=386", "GOHOSTARCH=386"},
})
addBuilder(BuildConfig{
Name: "darwin-amd64-10_12",
Expand Down
4 changes: 2 additions & 2 deletions dashboard/builders_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -467,8 +467,8 @@ func TestBuilderConfig(t *testing.T) {
{b("darwin-amd64-10_10@go1.12", "go"), onlyPost},
{b("darwin-amd64-10_10@go1.11", "go"), onlyPost},
{b("darwin-386-10_14", "go"), onlyPost},
{b("darwin-386-10_14@go1.12", "go"), onlyPost},
{b("darwin-386-10_14@go1.11", "go"), onlyPost},
{b("darwin-386-10_14@go1.12", "go"), none},
{b("darwin-386-10_14@go1.13", "go"), onlyPost},

// plan9 only lived at master. We didn't support any past releases.
// But it's off for now as it's always failing.
Expand Down

0 comments on commit b3adf7c

Please sign in to comment.