-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v4] git as implied requirement #1320
Comments
Typo fixed in #1343! Whether git is an intentional requirement for uploading remains an open question. |
@rohan-at-sentry to investigate and prioritize, the CLI I think is not |
@DArtagan , yes Were you able to find a workaround for your usecase? |
I couldn't find documentation about it, so we've just not upgraded to v4. |
@DArtagan this is now documented better on our docs here. I'm wondering if you were able to try running the CLI in docker as outlined here? |
I do appreciate the updated docs. Honestly, when setting it up the Action - we just used what was written in the README of this repo. (I don't think that README yet mentions that this Action is dependent on a Git binary.) If I'm following, the "Running test within containers" link you included seems to be a short two sentences linking to "Here's how you can set up Codecov CLI to upload to Codecov". That page suggests CURLing a script from a URL and bash-executing it to set environment variables? Emotional reaction: that gives me the heebie-jeebies for a production pipeline - one has no control over what's on the other side of the URL, it feels unsafe. No hashing or anything to guarantee consistent deterministic behaviour. But it also wouldn't install Git into the container either. Happily our Workflow is pretty much right out of the README example. Though we first ask the GitHub runner to spin up the container, and then run all following commands inside it:
|
Hi, I've been tracking the progress of v4 - to move our company over when possible.
We run our tests and codecov in a container. With this most recent version (4.1.0), an error is thrown:
Which makes sense - we don't have git installed inside that container. Is it intentionally a requirement for uploading with codecov?
In looking for a work-around I also noticed one possible typo I wanted to raise,
diable
. For example:const disableSafeDirectory = isTrue(core.getInput('diable_safe_directory'));
Thanks - let me know if there's any additional information I can provide.
The text was updated successfully, but these errors were encountered: