Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using to tokenless upload although a token is given #1457

Closed
leofeyer opened this issue May 27, 2024 · 1 comment
Closed

Using to tokenless upload although a token is given #1457

leofeyer opened this issue May 27, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@leofeyer
Copy link
Contributor

I just noticed that the action always switches to tokenless upload when the PR is in a forked repo.

The PR is happening in a forked repo. Using tokenless upload.

But the token is available in the forked repo, too, so the uploader could use it. It just does not seem to check this.

if (isPullRequestFromFork()) {
core.info('==> Fork detected, tokenless uploading used');
return Promise.resolve('');
}
let token = core.getInput('token');

Can you adjust this so that isPullRequestFromFork() is only called if there is no token?

@thomasrockhu-codecov thomasrockhu-codecov added the bug Something isn't working label May 28, 2024
@thomasrockhu-codecov
Copy link
Contributor

Thanks @leofeyer, I think this is a side effect of this overarching issue. Although can be accepted in this manner, I don't think this is the right long term solution.

I'm going to close this, because I recommend following the issue above as it should alleviate the tokenless issue with forks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants